The app theme (light, dark, etc) should respect the system theme
planned
Jason Manakis
On iOS and Android, most apps will change their theme based on the system theme, e.g. if Dark Mode is set to on, an app will also change its theme to dark. Currently in XUMM, the app’s theme can only be changed manually. There should be an option to set a light theme and a dark theme, and an option to respect the system theme so that the app’s theme can dynamically change.
Wietse Wind
I propose that this is a toggle above the theme setting: "Follow system theme", in which case the light mode is disabled. Users can then select the dark mode theme of their liking, after which Xumm will use light vs the selected dark theme based on OS indicator.
Fanil Jr
I can do it - very quickly. But I'm not on the development team.
On swift:
.backgroundColor - .systemBackground
public extension UIColor {
static func createColor(light: UIColor, dark: UIColor) -> UIColor {
guard #available(iOS 13.0, *) else { return light }
return UIColor { ( traitCollection) -> UIColor in
return traitCollection.userInterfaceStyle == .dark ? dark : light }
}
}
Wietse Wind
planned
Wietse Wind
I propose that this is a toggle above the theme setting: "Follow system theme", in which case the light mode is disabled. Users can then select the dark mode theme of their liking, after which Xumm will use light vs the selected dark theme based on OS indicator.
Burke Brunson
Wietse Wind: Even better idea than what I suggested - just wasn’t sure if this implementation would be feasible. Thank you, XRPL Labs Team!
Burke Brunson
I would suggest that the switch be between the “Default” and “Dark” themes for the auto-switch, personally.